Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't apply unnecessary DATE_TRUNC to base time spine column #1547

Open
wants to merge 2 commits into
base: court/simp6
Choose a base branch
from
Open

Don't apply unnecessary DATE_TRUNC to base time spine column #1547

wants to merge 2 commits into from

Conversation

courtneyholcomb
Copy link
Contributor

@courtneyholcomb courtneyholcomb commented Nov 23, 2024 •
edited
Loading

This will enable more efficient queries. We require the described grain to be accurate to the grain of the column, so this DATE_TRUNC is unnecessary.

@courtneyholcomb
Don't apply unnecessary DATE_TRUNC to base time spine column
74ba4b7 
This will enable more efficient queries. We require this grain to be accurate.
@courtneyholcomb courtneyholcomb changed the title Court/simp7 Don't apply unnecessary DATE_TRUNC to base time spine column Nov 23, 2024
@dbt-labs dbt-labs deleted a comment from github-actions bot Nov 23, 2024
@courtneyholcomb courtneyholcomb marked this pull request as ready for review November 23, 2024 06:00
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Nov 23, 2024
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plypaul plypaul Awaiting requested review from plypaul

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@courtneyholcomb