Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Time Spine Nodes in Dataflow Plan #1548

Open
wants to merge 7 commits into
base: court/simp7
Choose a base branch
from
Open

Include Time Spine Nodes in Dataflow Plan #1548

wants to merge 7 commits into from
+48,545 −31,898

Commits on Nov 23, 2024

  1. Support both MetricTimeDimensionTransformNodes and ReadSqlSourceNodes… 

    … for time spines

The metric time nodes are used for resolving metric_time without metrics. The read SQL nodes will be used for time spine joins.
    @courtneyholcomb
    courtneyholcomb committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    bcd959c View commit details
    Browse the repository at this point in the history

  2. Add TransformTimeDimensionsNode

    @courtneyholcomb
    courtneyholcomb committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    f6f44f0 View commit details
    Browse the repository at this point in the history

  3. Add logic to build time spine nodes in the dataflow plan 

    This will allow us to stop building time spine nodes on the fly in the dataflow to SQL logic.
    @courtneyholcomb
    courtneyholcomb committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    1ec4c63 View commit details
    Browse the repository at this point in the history

  4. Integrate new time spine nodes into JoinToTimeSpineNodes

    @courtneyholcomb
    courtneyholcomb committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    2808b0b View commit details
    Browse the repository at this point in the history

  5. Update DuckDB snapshots

    @courtneyholcomb
    courtneyholcomb committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    027a5bb View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Add tests for join to time spine metrics with custom grain filters

    @courtneyholcomb
    courtneyholcomb committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    585b698 View commit details
    Browse the repository at this point in the history

  2. Update SQL engine snapshots

    @courtneyholcomb
    courtneyholcomb committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    492043e View commit details
    Browse the repository at this point in the history