Add dbt-duckdb as a supported adapter and use it for local dev/test #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlento
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
LGTM, thanks so much!
I think removing the last straggling dev-only SQLAlchemy dependency is beyond the scope of this PR. I'll file a separate issue to clean up some of this adapter configuration logic, and we can decide what to do about the environment configuration for the dbt profiles (and whether or not to replace the SQLAlchemy URL inputs) at that time.
Comment on lines
+6
to
+8
| ## DuckDB | ||
|
|
||
| We assume that you have SQLite installed in your environment. By default, tests will run with SQLite. | ||
| By default, tests will run with DuckDB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #583 (well, sort of)
Description
Adds dbt-duckdb as a supported adapter type and uses it for local dev/test workflows instead of the existing sqlalchemy-based client, which is removed. Note that this only partially addresses #583 in that it does not remove all of the sqlalchemy dependencies because I felt like doing that much surgery to the code was above my paygrade, but if you all have a rough plan of what that would look like I am happy to add it in to this PR to fully close out the issue.