Added the flexible language path in TranslationConfiguration
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the `absoluteLanguageDirectory` param in `TranslationConfiguration` type. - Refactored code in `determineLaravelVersion` function. - Refactored code in `Loader` file to separate and improve the logic. - Created a file for `mergeDeep` function.
lionslair
approved these changes
Jul 11, 2024
lionslair
approved these changes
Jul 11, 2024
|
@lionslair Hi, sorry for the question, did we get any update about the future of this PR? 😅 |
|
Yeah still waiting for college to look it over too |
immersedone
approved these changes
Oct 20, 2024
|
@immersedone @lionslair Conflicts resolved. |
|
I don't think this works, typescript forced me to add .js at the end of the import. But you haven't added it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR added the absoluteLanguageDirectory parameter in the TranslationConfiguration type to define a custom language directory if needed.
By default, if the Laravel version is lower than v9, the directory is
resources/lang. Otherwise, the directory will belang/in the root project. This validation causes a problem if the project version is higher than v9 and it saves the localization files in theresources/langdirectory. A simple solution is to create a symbolic link from theresources/langdirectory to thelang/directory in the root project. However, ideally, people should configure a custom directory if needed from the Vite configuration to avoid creating unnecessary processes to solve problems with the language directory.absoluteLanguageDirectoryparam inTranslationConfigurationtype.determineLaravelVersionfunction.Loaderfile to separate and improve the logic.mergeDeepfunction.Testplan