Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ordering to properties where required #48

Merged
merged 10 commits into from
Oct 31, 2024

Conversation

DanSmith
Copy link
Contributor

@DanSmith DanSmith commented Oct 7, 2024

This work is based on the requirements in #23

Ordering was added to:

  • Item Groups
  • Variables in records
  • Group/Study/Datacollection structures
  • Survey Instruments

Copy link
Collaborator

@wlthomas wlthomas Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VariablesInRecord was not originally intended to define order of variables. That was done in the physical description. A logical record could be organized in multiple ways. If this is optional, I guess its OK.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these ordered? Just curious

@DanSmith
Copy link
Contributor Author

I've reviewed the items listed in #49 for cardinality checks.

Several of the items on the list were actually 0..1 in the schema so no changes were needed.
Items that had a mismatch in cardinality between the 3.3 schema and the model were updated in d5212b8

@DanSmith DanSmith self-assigned this Oct 16, 2024
@DanSmith DanSmith added this to the DDI Lifecycle 4.0 milestone Oct 16, 2024
@DanSmith DanSmith merged commit a51aa67 into ddialliance:master Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants