Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Unknown Functions Reply to Client #54

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

pseudotronics
Copy link

Changed the default case in handle_req_fc to respond instead of silently erroring. This should be done to avoid the connection timing out.

Most clients expect a response even when the function is unsupported.

@debevv
Copy link
Owner

debevv commented Jun 25, 2024

Right, this was probably made when the calling function was supposed to call send_exception_msg() with the returned error. Shame that tests didn't catch this.
Thank you

@debevv debevv merged commit 67bd7b2 into debevv:master Jun 25, 2024
2 checks passed
@pseudotronics pseudotronics deleted the Illegal-Function-Default-Case branch June 25, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants