Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-7384 mysql-replication example: set fixed mysql version 8.2 #361

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

MartinMedek
Copy link
Contributor

@MartinMedek MartinMedek commented Jan 23, 2024

No description provided.

@MartinMedek MartinMedek changed the title replaced obsolete and deprecated mysql properties in mysql-replicatio… mysql-replication example: set fixed mysql version 8.2 Jan 23, 2024
@MartinMedek MartinMedek marked this pull request as ready for review January 23, 2024 13:04
@MartinMedek MartinMedek requested a review from jpechane January 23, 2024 13:04
@jpechane
Copy link
Contributor

@MartinMedek LGTM! Could you please create a Jira issue with the description and modify the commit message to link to the DBZ-xxx so we keep tracking for the reason of this change? Thanks

@MartinMedek MartinMedek changed the title mysql-replication example: set fixed mysql version 8.2 DBZ-7384 mysql-replication example: set fixed mysql version 8.2 Jan 24, 2024
@MartinMedek MartinMedek force-pushed the fix-mysql-replication-cnf branch from cd56967 to 3ffd8d8 Compare January 24, 2024 07:38
@MartinMedek MartinMedek force-pushed the fix-mysql-replication-cnf branch from 3ffd8d8 to ba9e3b1 Compare January 24, 2024 07:40
@jpechane jpechane merged commit 7083dbb into debezium:main Jan 24, 2024
5 checks passed
@jpechane
Copy link
Contributor

@MartinMedek Applied, thanks

@@ -1,4 +1,4 @@
FROM mysql:latest
FROM mysql:8.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpechane @MartinMedek How come that Debezium 2.2 (released in April and May 2023) can use MySQL 8.2 here, which was released at the end of October 2023. Debezium 2.3.3/2.4.x are the earliest versions that should use it, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rk3rn3r While technically corect I think we can keep it as is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for this change in all those versions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the Dockerfile was just copied over instead of checking which MySQL version is the maximum one tested with. I really don't think this is real issue. These examples images are just used for testing. I'd recommend to not spent any more time discussing it as we are now on 2.5 anyway.
Maybe we can just take a mental notice that in the next case we don't need to touch the older images at all as they are on obsolete branch and we are not bound to fix them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well none of the images worked since 8.3 mysql release. In theory I could fix just the versions, that support mysql 8.2 and leave the rest broken (?). I didn't go though the older versions of Debezium and their supported mysql versions because this image is used just in system testsuite, that always uses latest version so additional testing of various mysql versions wasn't worth the effort.

@MartinMedek MartinMedek deleted the fix-mysql-replication-cnf branch January 25, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants