-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBZ-7384 mysql-replication example: set fixed mysql version 8.2 #361
Conversation
@MartinMedek LGTM! Could you please create a Jira issue with the description and modify the commit message to link to the DBZ-xxx so we keep tracking for the reason of this change? Thanks |
cd56967
to
3ffd8d8
Compare
3ffd8d8
to
ba9e3b1
Compare
@MartinMedek Applied, thanks |
@@ -1,4 +1,4 @@ | |||
FROM mysql:latest | |||
FROM mysql:8.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpechane @MartinMedek How come that Debezium 2.2 (released in April and May 2023) can use MySQL 8.2 here, which was released at the end of October 2023. Debezium 2.3.3/2.4.x are the earliest versions that should use it, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rk3rn3r While technically corect I think we can keep it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason for this change in all those versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the Dockerfile was just copied over instead of checking which MySQL version is the maximum one tested with. I really don't think this is real issue. These examples images are just used for testing. I'd recommend to not spent any more time discussing it as we are now on 2.5 anyway.
Maybe we can just take a mental notice that in the next case we don't need to touch the older images at all as they are on obsolete branch and we are not bound to fix them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well none of the images worked since 8.3 mysql release. In theory I could fix just the versions, that support mysql 8.2 and leave the rest broken (?). I didn't go though the older versions of Debezium and their supported mysql versions because this image is used just in system testsuite, that always uses latest version so additional testing of various mysql versions wasn't worth the effort.
No description provided.