ControlProxyWallet contract #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…size and gas consumption
artyukh
reviewed
Dec 16, 2021
| bytes memory data | ||
| ) external payable onlyCallProxyFromControllingAddress returns (bool _result) { | ||
| if (token != address(0)) { | ||
| IERC20Upgradeable(token).safeApprove(destination, 0); |
There was a problem hiding this comment.
Maybe add a bool needAprove argument?
There was a problem hiding this comment.
if the user needs just transfer token from his wallet he doesn't need to create approve
Vsevo1od
force-pushed
the
feature/control-wallet
branch
2 times, most recently
from
88edccb
to
b0f8135
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.