Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: ✨ configure canonical link #460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

braanj
Copy link

@braanj braanj commented Dec 17, 2024

All pages will have a self canonical (URL without trailing slash)

URLs with trailing slash are redirected permanently (301) to avoid duplicates in google index

All pages will have a self canonical (URL without trailing slash)

URLs with trailing slash are redirected permanently (301) to avoid duplicates in google index
@debs-obrien debs-obrien requested a review from Copilot December 17, 2024 20:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

server/middleware/removeTrailingSlash.js:1

  • The new middleware for removing trailing slashes should have corresponding test cases to ensure its functionality is verified.
export default defineEventHandler((event) => {

app.vue Show resolved Hide resolved
@braanj
Copy link
Author

braanj commented Dec 21, 2024

@debs-obrien The path is used to create the canonical link, which only makes sense when the page is first loaded. It therefore doesn't need to be reactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant