Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint issues and dynamic plugin exporting #3

Conversation

Zaperex
Copy link

@Zaperex Zaperex commented May 6, 2024

Description

  • Fixes yarn lint issues (installed missing dependencies as well)
  • Added a turbo.json and modified the tsconfig.json to output dist-types to the proper location
  • Updated the package.json to export alpha package for new backend system (and dynamic plugins for new backend system)

Signed-off-by: Frank Kong <frkong@redhat.com>
@debsmita1 debsmita1 merged commit 9fdbc9d into debsmita1:timestamp-custom-action May 7, 2024
1 check failed
@Zaperex Zaperex deleted the scaffolder-annotator-custom-action branch May 7, 2024 13:03
debsmita1 added a commit that referenced this pull request May 10, 2024
* chore(deps): update to backstage 1.26.x

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* update to new backend

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* update to 1.26.4

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* lint

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix scripts

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* update frontend to match showcase

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* format files

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix keycloak test

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix(deps): remove react-router-dom from dev dependencies and as it's there in peer dependency (#2)

* update to backstage 1.26.5

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix kiali

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* revert to basic frontend

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix linting

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix lint config

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* lint files

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* update dist-dynamic

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix resolutions

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* update react-router-dom

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix react deps

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix deprecations

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* potential fix for react

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix dep resolution

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* skip orchestrator test

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* add eslint rule

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix tsc error

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix(orchestrator): force react dependency to be 18.3 and return test (#3)

resolved issue that caused orchestrator to install it's own react version
thus causing the test to fail and the entire page to crash.

* fix(e2e): update e2e tests to allow guest login (#4)

* update common test file

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* update lockfiles

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix react

Signed-off-by: Paul Schultz <pschultz@pobox.com>

---------

Signed-off-by: Paul Schultz <pschultz@pobox.com>
Co-authored-by: Jaivardhan Kumar <mailjai.vardhan@gmail.com>
Co-authored-by: Bat-Zion Rotman <brotman@redhat.com>
Co-authored-by: Debsmita Santra <debsmita.santra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants