Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer dependencies doesn't configure correctly #7204

Closed
wants to merge 5 commits into from

Conversation

kamontat
Copy link

closes #7203

Summary

If you install decap-cms-app with strict-peer-dependencies enabled. You will get peer dependencies error.

Test plan

Just update dependencies to satisfies peer dependencies

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)

image

@kamontat kamontat requested a review from a team as a code owner May 10, 2024 03:14
Copy link
Member

@martinjagodic martinjagodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamontat this update is not so simple it appears, the builds are failing. Please look into how to best update the dependency. I changed the import, but there are still problems.

@martinjagodic
Copy link
Member

I also tried to update unified and other remark dependencies in #7266, but I failed. Jest will not handle them, because they are not common js modules in recent versions.

Let's wait until jest adds support for es6 modules. Until then, I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When install decap-cms-widget-markdown, it throw unmet peer error
3 participants