Fix lint workflow #358
Merged
Fix lint workflow #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decidim-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreslucena
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rubocop inherits from the decidim rubocop config files, it broke after merging decidim/decidim#13146.
This PR fixes it. Basically we add
rubocop-rspec_railsdependency, as well as addingrubocop-capybaraas required file in.rubocop.ymlto get rid of a message when executing it.The missing gem is what updates the different gem versions.
This solution really does not make a lot of sense, since this is not a ror application, but in order to not duplicate the rubocop files in de
decidim-devthis is the easiest solution.