Remove unmasked variables, and outputs (#2)

* Remove unmasked variables in pipeline

* Added extra commands and removed test pulumi stack

.github/workflows/crawler.yml

@@ -1,6 +1,9 @@
 name: Crawlers
 
-on: [pull_request]
+on:
+  push:
+    branches:
+      - main
 
 jobs:
   build:
@@ -15,12 +18,9 @@ jobs:
           aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           aws-region: ${{ secrets.AWS_REGION }}
-          mask-aws-account-id: 'false'
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
-        with:
-          mask-password: 'false'
       - name: Build images & push to ECR
         id: build-image
         uses: docker/build-push-action@v4
@@ -31,8 +31,6 @@ jobs:
             ${{ steps.login-ecr.outputs.registry }}/crawler:${{ github.sha }}
             ${{ steps.login-ecr.outputs.registry }}/crawler:latest
           push: true
-    outputs:
-      registry: ${{ steps.login-ecr.outputs.registry }}
 
   deploy:
     name: Deploy Crawler
@@ -55,6 +53,6 @@ jobs:
           echo "Successfully updated lambda"
         env:
           AWS_REGION: ${{ secrets.AWS_REGION }}
-          ECR_REPOSITORY: ${{ needs.build.outputs.registry }}
+          ECR_REPOSITORY: ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.${{ secrets.AWS_REGION }}.amazonaws.com
           PROJECT_VERSION: ${{ github.sha }}
           AWS_ACCOUNT_ID: ${{ secrets.AWS_ACCOUNT_ID }}

course/module1/Makefile

@@ -1,3 +1,6 @@
+AWS_CURRENT_REGION_ID := $(shell aws configure get region)
+AWS_CURRENT_ACCOUNT_ID := $(shell aws sts get-caller-identity --query "Account" --output text)
+
 help:
 	@grep -E '^[a-zA-Z0-9 -]+:.*#'  Makefile | sort | while read -r l; do printf "\033[1;32m$$(echo $$l | cut -f 1 -d':')\033[00m:$$(echo $$l | cut -f 2- -d'#')\n"; done
 
@@ -14,13 +17,20 @@ local-test: # Send test command on local to test  the lambda
 	curl -X POST "http://localhost:9000/2015-03-31/functions/function/invocations" \
 	  	-d '{"user": "Paul Iuztin", "link": "https://medium.com/@pauliusztin/the-llms-kit-build-a-production-ready-real-time-financial-advisor-system-using-streaming-ffdcb2b50714"}'
 
-invoke:
+invoke: # Invoke remote lambda from local
 	aws lambda invoke \
 		--function-name crawler \
 		--cli-binary-format raw-in-base64-out \
 		--payload '{"user": "Paul Iuztin", "link": "https://github.com/iusztinpaul/hands-on-llms"}' \
 		response.json
 
+push: # Build & push image to docker ECR (e.g make push IMAGE_TAG=latest)
+	echo "Logging into AWS ECR..."
+	aws ecr get-login-password --region $(AWS_CURRENT_REGION_ID) | docker login --username AWS --password-stdin $(AWS_CURRENT_ACCOUNT_ID).dkr.ecr.$(AWS_CURRENT_REGION_ID).amazonaws.com
+	echo "Build & Push Docker image..."
+	docker buildx build --platform linux/amd64 -t $(AWS_CURRENT_ACCOUNT_ID).dkr.ecr.$(AWS_CURRENT_REGION_ID).amazonaws.com/crawler:$(IMAGE_TAG) .
+	echo "Push completed successfully."
+
 clean: # Cleanup files generated during sam building.
 	@echo "Cleaning old files..."
 	rm -rf /.pytest_cache