Fix bevm sonarcloud cognitive complexity issues

[cgrigis]

What this PR does

See commit message

[ineiti]

Nice try - but sonarcloud doesn't like it :( I think the test coverage is not there yet...

[cgrigis]

Nice try - but sonarcloud doesn't like it :( I think the test coverage is not there yet...

I don't think it is the coverage it is complaining about, but the "duplicate lines on new code". However, what it considers "new code" has very little to do with what the PR is touching, so I am not sure how it is determining it.

[tharvik]

I don't think it is the coverage it is complaining about, but the "duplicate lines on new code".

Correct, from what I gather from the checks page.

However, what it considers "new code" has very little to do with what the PR is touching, so I am not sure how it is determining it.

Badly IMO. We might want to do a sonar cloud initial pass, but I dunno how to trigger it on the whole repo.

[cgrigis]

We might want to do a sonar cloud initial pass, but I dunno how to trigger it on the whole repo.

Yes, exactly what I was thinking as well. :)

[ineiti]

But we still need to enable coverage:

No Coverage information

[ineiti]

And probably you need to rebase from master to have the github-actions...

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
5.8% Duplication