Skip to content

Commit

Permalink
Added back circl deserialization test (cloudflare/circl#499)
Browse files Browse the repository at this point in the history
  • Loading branch information
matteosz committed Jun 12, 2024
1 parent 7c1f43e commit 3645026
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 11 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module go.dedis.ch/kyber/v4
go 1.20

require (
github.com/cloudflare/circl v1.3.7
github.com/cloudflare/circl v1.3.9
github.com/consensys/gnark-crypto v0.12.1
github.com/jonboulle/clockwork v0.4.0
github.com/kilic/bls12-381 v0.1.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
github.com/bits-and-blooms/bitset v1.13.0 h1:bAQ9OPNFYbGHV6Nez0tmNI0RiEu7/hxlYJRUA0wFAVE=
github.com/bits-and-blooms/bitset v1.13.0/go.mod h1:7hO7Gc7Pp1vODcmWvKMRA9BNmbv6a/7QIWpPxHddWR8=
github.com/cloudflare/circl v1.3.7 h1:qlCDlTPz2n9fu58M0Nh1J/JzcFpfgkFHHX3O35r5vcU=
github.com/cloudflare/circl v1.3.7/go.mod h1:sRTcRWXGLrKw6yIGJ+l7amYJFfAXbZG0kBSc8r4zxgA=
github.com/cloudflare/circl v1.3.9 h1:QFrlgFYf2Qpi8bSpVPK1HBvWpx16v/1TZivyo7pGuBE=
github.com/cloudflare/circl v1.3.9/go.mod h1:PDRU+oXvdD7KCtgKxW95M5Z8BpSCJXQORiZFnBQS5QU=
github.com/consensys/bavard v0.1.13 h1:oLhMLOFGTLdlda/kma4VOJazblc7IM5y5QPd2A/YjhQ=
github.com/consensys/bavard v0.1.13/go.mod h1:9ItSMtA/dXMAiL7BG6bqW2m3NdSEObYWoH223nGHukI=
github.com/consensys/gnark-crypto v0.12.1 h1:lHH39WuuFgVHONRl3J0LRBtuYdQTumFSDtJF7HpyG8M=
Expand Down
8 changes: 0 additions & 8 deletions pairing/bls12381/bls12381_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,6 @@ func TestZKCryptoVectorsG1Compressed(t *testing.T) {
tests, err := filepath.Glob(deserializationG1Tests)
require.NoError(t, err)

// Remove from tests "deserialization_fails_with_b_flag_and_a_flag_true.yaml", failing on Circl (index 6)
// https://github.com/cloudflare/circl/issues/499 - Remove the line when the issue is fixed
tests = append(tests[:6], tests[7:]...)

for _, testPath := range tests {
t.Run(testPath, func(t *testing.T) {
testFile, err := os.Open(testPath)
Expand Down Expand Up @@ -127,10 +123,6 @@ func TestZKCryptoVectorsG2Compressed(t *testing.T) {
tests, err := filepath.Glob(deserializationG2Tests)
require.NoError(t, err)

// Remove from tests "deserialization_fails_with_b_flag_and_a_flag_true.yaml", failing on Circl (index 6)
// https://github.com/cloudflare/circl/issues/499 - Remove the line when the issue is fixed
tests = append(tests[:6], tests[7:]...)

for _, testPath := range tests {
t.Run(testPath, func(t *testing.T) {
testFile, err := os.Open(testPath)
Expand Down

0 comments on commit 3645026

Please sign in to comment.