Add EDDSA test-vectors #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierluca
requested changes
Sep 1, 2024
There was a problem hiding this comment.
This looks good to me. I'd try to embed the wycheproof license (Apache License 2.0) along with the code though.
K1li4nL
force-pushed
the
add-ed25519-vectors
branch
from
ca1c991
to
d4a64a2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add test vectors to kyber eddsa implementation from the following source: https://github.com/C2SP/wycheproof/blob/0d2dab394df1eb05b0865977f7633d010a98bccd/testvectors_v1/ed25519_test.json