Skip to content

Commit

Permalink
Followup to review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
jcferretti committed Nov 6, 2024
1 parent c39c6bb commit 3938226
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import io.deephaven.protobuf.ProtobufFunction;
import io.deephaven.protobuf.ProtobufFunctions;
import io.deephaven.protobuf.ProtobufFunctions.Builder;
import io.deephaven.protobuf.ToChunkTypeTransform;
import io.deephaven.function.ToChunkTypeTransform;
import io.deephaven.qst.type.Type;
import io.deephaven.util.annotations.VisibleForTesting;
import io.deephaven.util.mutable.MutableInt;
Expand All @@ -56,7 +56,7 @@
/**
* This layer builds on top of {@link ProtobufDescriptorParser#parse(Descriptor, ProtobufDescriptorParserOptions)} by
* further transforming the functions according to {@link #withMostAppropriateType(TypedFunction)}, and then further
* adapting the functions to ensure they work for the expected chunk types {@link io.deephaven.protobuf.ToChunkTypeTransform}. This layer is
* adapting the functions to ensure they work for the expected chunk types {@link ToChunkTypeTransform}. This layer is
* also responsible for managing schema changes; in essence, ensuring that newly
* {@link ProtobufDescriptorParser#parse(Descriptor, ProtobufDescriptorParserOptions) parsed} {@link Descriptor
* descriptor} {@link TypedFunction functions} can be adapted into the original function type.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
//
// Copyright (c) 2016-2024 Deephaven Data Labs and Patent Pending
//
package io.deephaven.protobuf;
package io.deephaven.function;

import io.deephaven.function.*;
import io.deephaven.qst.type.ArrayType;
import io.deephaven.qst.type.BoxedBooleanType;
import io.deephaven.qst.type.BoxedByteType;
Expand Down

0 comments on commit 3938226

Please sign in to comment.