Review comments

deephaven · Sep 18, 2023 · 43034fb · 43034fb
1 parent a4fb2f6
commit 43034fb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetInstructions.java b/extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetInstructions.java
@@ -29,9 +29,10 @@ public abstract class ParquetInstructions implements ColumnToCodecMappings {
  /**
  * Set the default for {@link #getCompressionCodecName()}.
  *
+ * @deprecated Do not use this method directly, instead use {@link Builder#setCompressionCodecName(String)}.
  * @param name The new default
- * @see Builder#setCompressionCodecName(String)
  */
+ @Deprecated
  public static void setDefaultCompressionCodecName(final String name) {
  defaultCompressionCodecName = name;
  }

diff --git a/extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java b/extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
@@ -845,8 +845,8 @@ public static Pair<List<ColumnDefinition<?>>, ParquetInstructions> convertSchema
  ParquetInstructions.builder().setCompressionCodecName("UNCOMPRESSED").build();
 
  /**
- * Deprecated: Use LZ4_RAW instead, as explained
- * <a href="https://github.com/apache/parquet-format/blob/master/Compression.md">here</a>
+ * @deprecated Use LZ4_RAW instead, as explained
+ *  <a href="https://github.com/apache/parquet-format/blob/master/Compression.md">here</a>
  */
  @Deprecated
  public static final ParquetInstructions LZ4 = ParquetInstructions.builder().setCompressionCodecName("LZ4").build();
@@ -864,8 +864,8 @@ public static Pair<List<ColumnDefinition<?>>, ParquetInstructions> convertSchema
  public static final ParquetInstructions LEGACY = ParquetInstructions.builder().setIsLegacyParquet(true).build();
 
  /**
- * Deprecated: Do not use this method directly, instead pass the above codecs as arguments to
- * {@link #writeTable(Table, File, ParquetInstructions)} method
+ * @deprecated Do not use this method directly, instead pass the above codecs as arguments to
+ *  {@link #writeTable(Table, File, ParquetInstructions)} method
  */
  @Deprecated
  public static void setDefaultCompressionCodecName(final String compressionCodecName) {