For docker runs (tests) ensure we get results even when the run (test…

…) fails. (#4254)

* Ensure the buildAndRun task runs the sync task even if it fails.

* Followup to review comment.

* Recover previous fix.

* Followup to review comments.

buildSrc/src/main/groovy/Docker.groovy

@@ -302,8 +302,19 @@ class Docker {
             // Single task with explicit inputs and outputs, to let gradle detect if it is up to date, and let docker
             // cache what it can.
 
+            // Sync outputs to the desired location
+            def syncAfterBuildAndRun = project.tasks.register("${taskName}Sync", Sync) { sync ->
+                sync.with {
+                    // run the provided closure first
+                    cfg.copyOut.execute(sync)
+
+                    // then set the from location
+                    from dockerCopyLocation
+                }
+            }
+
             // Note that if "showLogsOnSuccess" is true, we don't run this way, since that would omit logs when cached.
-            def buildAndRun = project.tasks.register("${taskName}Run", CombinedDockerRunTask) { cacheableDockerTask ->
+            return project.tasks.register(taskName, CombinedDockerRunTask) { cacheableDockerTask ->
                 cacheableDockerTask.with {
                     // mark inputs, depend on dockerfile task and input sync task
                     inputs.files(makeImage.get().outputs.files)
@@ -334,18 +345,7 @@ class Docker {
 
                     remotePath.set(cfg.containerOutPath)
                     outputDir.set(project.file(dockerCopyLocation))
-                }
-            }
-            // Sync outputs to the desired location
-            return project.tasks.register(taskName, Sync) { sync ->
-                sync.with {
-                    dependsOn buildAndRun
-
-                    // run the provided closure first
-                    cfg.copyOut.execute(sync)
-
-                    // then set the from location
-                    from dockerCopyLocation
+                    finalizedBy syncAfterBuildAndRun
                 }
             }
         }

buildSrc/src/main/groovy/io/deephaven/tools/docker/CombinedDockerRunTask.groovy

@@ -111,6 +111,7 @@ class CombinedDockerRunTask extends AbstractDockerRemoteApiTask {
                     throw new GradleException("${failedMessage}, check logs for details")
                 }
             }
+
         } finally {
             if (containerId == null) {
                 return;

cpp-client/build.gradle

@@ -124,5 +124,5 @@ def testCppClient = Docker.registerDockerTask(project, 'testCppClient') {
     parentContainers = [ Docker.registryTask(project, 'cpp-client-base') ]
     entrypoint = ['/cpp-client/install/bin/cpp-tests-to-junit.sh', '/out/cpp-test.xml', '/out/cpp-test.log']
 }
-deephavenDocker.shouldLogIfTaskFails tasks.named('testCppClientRun')
+deephavenDocker.shouldLogIfTaskFails testCppClient
 tasks.check.dependsOn(testCppClient)

go/build.gradle

@@ -86,5 +86,5 @@ def testGoClient = Docker.registerDockerTask(project, 'testGoClient') {
     parentContainers = [ Docker.registryTask(project, 'go') ]
     entrypoint = ['./go-test-to-junit.sh', '/out/go-test.xml', '/out/go.log']
 }
-deephavenDocker.shouldLogIfTaskFails tasks.named('testGoClientRun')
+deephavenDocker.shouldLogIfTaskFails testGoClient
 tasks.check.dependsOn(testGoClient)

py/client/build.gradle

@@ -81,7 +81,7 @@ deephavenDocker {
     networkName.set "pydeephaven-network-${randomSuffix}"
 }
 
-tasks.getByName('check').dependsOn(Docker.registerDockerTask(project, 'testPyClient') {
+def testPyClient = Docker.registerDockerTask(project, 'testPyClient') {
     copyIn {
         from('pydeephaven') {
             into 'project/pydeephaven'
@@ -112,5 +112,7 @@ tasks.getByName('check').dependsOn(Docker.registerDockerTask(project, 'testPyCli
     copyOut {
         into layout.buildDirectory.dir('test-results')
     }
-})
-deephavenDocker.shouldLogIfTaskFails tasks.named('testPyClientRun')
+}
+
+tasks.getByName('check').dependsOn(testPyClient)
+deephavenDocker.shouldLogIfTaskFails testPyClient