Skip to content

Commit

Permalink
Followup to review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
jcferretti committed Aug 2, 2023
1 parent 6fdac2f commit 7e4aabd
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions buildSrc/src/main/groovy/Docker.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ class Docker {
}

// Note that if "showLogsOnSuccess" is true, we don't run this way, since that would omit logs when cached.
def buildAndRun = project.tasks.register(taskName, CombinedDockerRunTask) { cacheableDockerTask ->
return project.tasks.register(taskName, CombinedDockerRunTask) { cacheableDockerTask ->
cacheableDockerTask.with {
// mark inputs, depend on dockerfile task and input sync task
inputs.files(makeImage.get().outputs.files)
Expand Down Expand Up @@ -348,8 +348,6 @@ class Docker {
finalizedBy syncAfterBuildAndRun
}
}

return buildAndRun
}
// With no outputs, we can use the standard individual containers, and gradle will have to re-run each time
// the task is invoked, can never be marked as up to date.
Expand Down

0 comments on commit 7e4aabd

Please sign in to comment.