Skip to content

Commit

Permalink
Always half-close DoExchange snapshot requests (#4632)
Browse files Browse the repository at this point in the history
Partial mitigation for #4627
  • Loading branch information
niloc132 authored Oct 13, 2023
1 parent 6e081fe commit 9275306
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ public synchronized BarrageTable partialTable(RowSet viewport, BitSet columns, b
.setAppMetadata(ByteStringAccess.wrap(makeRequestInternal(viewport, columns, reverseViewport, options)))
.build());

observer.onCompleted();

while (!completed && exceptionWhileCompleting == null) {
// handle the condition where this function may have the exclusive lock
if (completedCondition != null) {
Expand All @@ -210,8 +212,6 @@ public synchronized BarrageTable partialTable(RowSet viewport, BitSet columns, b
}
}

observer.onCompleted();

if (exceptionWhileCompleting == null) {
return resultTable;
} else {
Expand Down

0 comments on commit 9275306

Please sign in to comment.