Apply suggestions from code review

Per @chipkent. Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
deephaven · Mar 15, 2024 · ae90b46 · ae90b46
1 parent 8bb8664
commit ae90b46
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/py/server/deephaven/jcompat.py b/py/server/deephaven/jcompat.py
@@ -307,7 +307,7 @@ def _j_array_to_series(dtype: DType, j_array: jpy.JType, conv_null: bool) -> pd.
 
 
 class SafeCloseable(JObjectWrapper):
-    """A context manager wrapper of Java SafeCloseable to emulate Java try-with-resources."""
+    """A context manager wrapper to allow Java SafeCloseable to be used in with statements."""
 
     j_object_type = jpy.get_type("io.deephaven.util.SafeCloseable")
 

diff --git a/py/server/tests/test_jcompat.py b/py/server/tests/test_jcompat.py
@@ -33,7 +33,7 @@ def int_to_str(v: int) -> str:
     def test_safe_closeable(self):
         safe_closeable = SafeCloseable(_JSharedContext.makeSharedContext())
         with safe_closeable:
-            pass
+            self.assertEqual(safe_closeable.closed, False)
         self.assertEqual(safe_closeable.closed, True)