Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Colin Alworth <colin@vertispan.com>
  • Loading branch information
mofojed and niloc132 authored Dec 4, 2023
1 parent 108936a commit cbc0ae3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ public Promise<JsTable> getTable(JsVariableDefinition varDef, @Nullable Boolean
}

/**
* Export a table from the provided ticket
* Export a table from the provided ticket.
*
* @param ticket Ticket of the table to export
* @param fetchSummary Description for the fetch. Used for logging and errors.
Expand Down Expand Up @@ -809,7 +809,7 @@ public Promise<?> getObject(TypedTicket typedTicket) {
}

/**
* Retrieve an object from it's definition
* Retrieve an object from its definition.
*
* @param definition Variable definition to get
* @return The object requested
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ public TypedTicket takeTicket() {
* Fetches the object from the server.
*
* @param takeOwnership Whether to take ownership of the object. Defaults to false.
*
* @return a promise that resolves to the object
*/
@JsMethod
Expand Down

0 comments on commit cbc0ae3

Please sign in to comment.