Skip to content

Commit

Permalink
fix: Mark JsPartitionedTable.getTable as nullable (#5050)
Browse files Browse the repository at this point in the history
- JsPartitionedTable.getTable returns `null` if the key is not found, as the table may not exist yet.
  • Loading branch information
mofojed authored Mar 7, 2024
1 parent da73346 commit ed1ba0b
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import io.deephaven.web.shared.data.RangeSet;
import jsinterop.annotations.JsIgnore;
import jsinterop.annotations.JsMethod;
import jsinterop.annotations.JsNullable;
import jsinterop.annotations.JsProperty;
import jsinterop.annotations.JsType;
import jsinterop.base.Js;
Expand Down Expand Up @@ -160,12 +161,12 @@ private void handleKeys(Event update) {
}

/**
* Fetch the table with the given key.
* Fetch the table with the given key. If the key does not exist, returns `null`.
*
* @param key The key to fetch. An array of values for each key column, in the same order as the key columns are.
* @return Promise of dh.Table
* @return Promise of dh.Table, or `null` if the key does not exist.
*/
public Promise<JsTable> getTable(Object key) {
public Promise<@JsNullable JsTable> getTable(Object key) {
// Wrap non-arrays in an array so we are consistent with how we track keys
if (!JsArray.isArray(key)) {
key = JsArray.of(key);
Expand Down

0 comments on commit ed1ba0b

Please sign in to comment.