Enable PSK by default, correct link to IDE #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
DocumentationNeeded
authentication
ReleaseNotesNeeded
mofojed
reviewed
Jun 12, 2023
docker-compose-common.yml
Outdated
| @@ -14,7 +14,7 @@ services: | |||
| # with max memory. | |||
| # | |||
| # To turn on debug logging, add: -Dlogback.configurationFile=logback-debug.xml | |||
| - START_OPTS=-Xmx4g -Ddeephaven.console.type=${DEEPHAVEN_CONSOLE_TYPE} -Ddeephaven.application.dir=${DEEPHAVEN_APPLICATION_DIR} | |||
| - START_OPTS=-Xmx4g -Ddeephaven.console.type=${DEEPHAVEN_CONSOLE_TYPE} -Ddeephaven.application.dir=${DEEPHAVEN_APPLICATION_DIR} -Dauthentication.psk=${PSK} | |||
There was a problem hiding this comment.
Env var should probably be named DEEPHAVEN_PSK for consistency
There was a problem hiding this comment.
Seems reasonable, my goal here was to keep the invocation short to default to something simple:
➜ core.new git:(psk-default) ✗ PSK=1234 docker-compose up
[+] Building 0.0s (0/0)
[+] Running 1/0
✔ Container core-server-1 Created 0.1s
Attaching to core-server-1
core-server-1 | 1 compiler directives added
core-server-1 | VM settings:
core-server-1 | Max. Heap Size: 4.00G
core-server-1 | Using VM: OpenJDK 64-Bit Server VM
core-server-1 |
core-server-1 | # Starting io.deephaven.server.jetty.JettyMain
...
core-server-1 | 2023-06-15T19:18:53.880Z | main | INFO | d.s.a.ApplicationInjector | found 0 exports
core-server-1 | 2023-06-15T19:18:53.880Z | main | INFO | .d.s.r.DeephavenApiServer | Initializing Authentication...
core-server-1 | 2023-06-15T19:18:53.881Z | main | WARN | .PskAuthenticationHandler |
core-server-1 | 2023-06-15T19:18:53.881Z | main | WARN | .PskAuthenticationHandler |
core-server-1 | 2023-06-15T19:18:53.881Z | main | WARN | .PskAuthenticationHandler |
core-server-1 | 2023-06-15T19:18:53.881Z | main | WARN | .PskAuthenticationHandler |
core-server-1 | 2023-06-15T19:18:53.881Z | main | WARN | .PskAuthenticationHandler |
core-server-1 | 2023-06-15T19:18:53.881Z | main | WARN | .PskAuthenticationHandler | ================================================================================
core-server-1 | 2023-06-15T19:18:53.882Z | main | WARN | .PskAuthenticationHandler | Superuser access through pre-shared key is enabled - use 1234 to connect
core-server-1 | 2023-06-15T19:18:53.882Z | main | WARN | .PskAuthenticationHandler | Connect automatically to Web UI with http://localhost:10000/?psk=1234
core-server-1 | 2023-06-15T19:18:53.882Z | main | WARN | .PskAuthenticationHandler | ================================================================================
core-server-1 | 2023-06-15T19:18:53.882Z | main | WARN | .PskAuthenticationHandler |
core-server-1 | 2023-06-15T19:18:53.882Z | main | WARN | .PskAuthenticationHandler |
core-server-1 | 2023-06-15T19:18:53.882Z | main | WARN | .PskAuthenticationHandler |
core-server-1 | 2023-06-15T19:18:53.882Z | main | WARN | .PskAuthenticationHandler |
core-server-1 | 2023-06-15T19:18:53.882Z | main | WARN | .PskAuthenticationHandler |
core-server-1 | 2023-06-15T19:18:53.882Z | main | INFO | .d.s.r.DeephavenApiServer | Starting server...
core-server-1 | 2023-06-15T19:18:53.884Z | main | INFO | o.e.jetty.server.Server | jetty-11.0.15; built: 2023-04-11T18:37:53.775Z; git: 5bc5e562c8d05c5862505aebe5cf83a61bdbcb96; jvm 17.0.7+7
For the "use this docker-compose.yml as a template", i would agree that something like DEEPHAVEN_PSK may be preferred. I'll take your guidance here, just offering my reasoning.
...le-providers/psk/src/main/java/io/deephaven/authentication/psk/PskAuthenticationHandler.java
Outdated
Show resolved
Hide resolved
...le-providers/psk/src/main/java/io/deephaven/authentication/psk/PskAuthenticationHandler.java
Show resolved
Hide resolved
rcaudy
reviewed
Jun 20, 2023
...le-providers/psk/src/main/java/io/deephaven/authentication/psk/PskAuthenticationHandler.java
Outdated
Show resolved
Hide resolved
Also generates a random key when an empty key is provided
chipkent
approved these changes
Jun 20, 2023
mofojed
approved these changes
Jun 21, 2023
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/2802 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also generates a random key when an empty key is provided.
Tested from gradle and docker-compose, but we'll certainly need more testing and verification before shipping this.