Better handling for uncommon/exception gRPC cases #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
grpc
NoDocumentationNeeded
ReleaseNotesNeeded
devinrsmith
reviewed
Jun 20, 2023
Comment on lines
80
to
84
| try { | ||
| outputStream.writeAndCloseWhenReady(payload.array(), safelyComplete); | ||
| } catch (IOException e) { | ||
| safelyComplete.run(); | ||
| } |
There was a problem hiding this comment.
It looks like writeAndCloseWhenReady already handles running the close when an IOException is thrown - are we explicitly doubling up here? Or, just re-running it b/c there isn't harm?
There was a problem hiding this comment.
Ah thanks - it used to be that an IOException was possible just accessing the output stream, but I rearranged that to ensure it couldn't happen... and left the try/catch.
GRPC servlet won't handle this error anyway.
devinrsmith
approved these changes
Jun 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes three logged errors. Two are handed by not permitting an error to be thrown into gRPC internals, but instead catch, cancel the stream, and log the error. The third case is handled by following the appropriate async write pattern required by servlets.
Fixes #3965
Fixes #3052