Simplify ScriptSession dependencies #4190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
python
DocumentationNeeded
groovy
ReleaseNotesNeeded
devinrsmith
previously approved these changes
Jul 17, 2023
chipkent
requested changes
Jul 19, 2023
|
|
||
| def init_py(): | ||
| """Finishes starting Python to be usable from inside of a Java process. Not intended to be called in cases | ||
| where there process was start as Python, and Java was started from inside Python. |
There was a problem hiding this comment.
Suggested change
| where there process was start as Python, and Java was started from inside Python. | |
| where there process was started as Python, and Java was started from inside Python. |
Comment on lines
+85
to
+86
| # If you want jpy to tell you about all that it is doing, change this | ||
| # jpy.diag.flags = jpy.diag.F_ALL |
There was a problem hiding this comment.
Should this be an ENV controlled option to help us debug users?
There was a problem hiding this comment.
That seems like a decent idea, but in a different PR (i'm just moving the contents of this file so we have one fewer way to screw up startup).
rcaudy
previously approved these changes
Jul 20, 2023
niloc132
dismissed stale reviews from rcaudy, jmao-denver, and devinrsmith
via
f123266
niloc132
force-pushed
the
4040-cleanup-3
branch
from
dc80e08
to
f123266
Compare
chipkent
approved these changes
Sep 19, 2023
rcaudy
approved these changes
Sep 19, 2023
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/3211 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the only python init script, and removes an unused groovy init script. The config variables are left in place for now, though they will default to blank.
One slightly unexpected change that this results in is that the
jpy,sys, andosmodules are no longer imported by default into a python script session - this probably should be considered a feature, but does need to be documented.In a future patch I'll propose unifying how init scripts are run, so that there is no potential loss in functionality. If reviewers would prefer, I can just go ahead and add those changes here too, though my aim was to let this be a smaller step by itself.