Improved handling of parquet writes for read-modify-write #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
parquet
malhotrashivam
force-pushed
the
sm-write-temp
branch
from
5554ed0
to
4d9ac43
Compare
rcaudy
reviewed
Jul 31, 2023
engine/table/src/main/java/io/deephaven/engine/util/file/TrackedFileHandleFactory.java
Outdated
Show resolved
Hide resolved
....deephaven.parquet.table.ParquetTableReadWriteTest_root/tempDir/readModifyWriteTests.parquet
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/file/TrackedFileHandleFactory.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTableWriter.java
Outdated
Show resolved
Hide resolved
...nsions/parquet/table/src/test/java/io/deephaven/parquet/table/ParquetTableReadWriteTest.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Show resolved
Hide resolved
rcaudy
reviewed
Aug 3, 2023
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTableWriter.java
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTableWriter.java
Outdated
Show resolved
Hide resolved
| for (Map.Entry<String, GroupingColumnWritingInfo> entry : groupingColumnsWritingInfoMap.entrySet()) { | ||
| final String groupingColumnName = entry.getKey(); | ||
| final Table auxiliaryTable = groupingAsTable(t, groupingColumnName); | ||
| final String parquetColumnName = entry.getValue().parquetColumnName; |
There was a problem hiding this comment.
General thing to think about:
ParquetWriteInstructions are used at multiple levels. This code could do with a cleanup around control flow and the responsibilities of each layer.
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTableWriter.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTableWriter.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
| } | ||
| throw e; |
There was a problem hiding this comment.
I don't understand why we didn't have to declare this in throws. Your existing version is better.
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
malhotrashivam
commented
Aug 6, 2023
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
malhotrashivam
commented
Aug 6, 2023
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Aug 9, 2023
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
malhotrashivam
changed the title
rcaudy
reviewed
Aug 9, 2023
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
malhotrashivam
changed the title
rcaudy
approved these changes
Aug 10, 2023
malhotrashivam
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix, closes #2831
Currently, while writing a parquet file, we overwrite if there is any existing files at that path. And in case the write fails (for whatever reason), we delete the partially written file. This is particularly bad for the read-modify-write scenario where we open a file handle to an existing parquet file, do some table operations and then try to write it at the same path. In the current case, we can overwrite the file while we are reading from it which will lead to a bad state.
In this PR, we are changing the write functionality by first writing to a temporary file in the same directory. Once the write completes, we place the file at its destination path and swap out if there is any existing files at that path.