Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractScriptSession.evaluateScript diff result fix #4217

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Jul 21, 2023

Ensure that the scope diff returned by AbstractScriptSession.evaluateScript includes all scope changes that occur during the evaluation, not just the ones not already reported to the change listener (in case of concurrent or nested propagation)

Fixes #4216

…Script includes all scope changes that occur during the evaluation, not just the ones not already reported to the change listener (in case of concurrent or nested propagation)
@rcaudy rcaudy added bug Something isn't working core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Jul 21, 2023
@rcaudy rcaudy added this to the July 2023 milestone Jul 21, 2023
@rcaudy rcaudy requested a review from niloc132 July 21, 2023 19:46
@rcaudy rcaudy self-assigned this Jul 21, 2023
@rcaudy rcaudy enabled auto-merge (squash) July 21, 2023 19:47
@rcaudy rcaudy merged commit fea3d43 into deephaven:main Jul 21, 2023
17 checks passed
@rcaudy rcaudy deleted the rwc-fix-evaluate-diff branch July 21, 2023 20:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConsoleService.executeCommand changes regression
2 participants