Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conv_null option in to_pandas() to convert DH nulls to pd.NA #4237

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Add conv_null option in to_pandas() to convert DH nulls to pd.NA #4237

merged 4 commits into from
Aug 2, 2023

Conversation

jmao-denver
Copy link
Contributor

Fixes #4207

@jmao-denver jmao-denver added this to the July 2023 milestone Jul 27, 2023
@jmao-denver jmao-denver self-assigned this Jul 27, 2023
@jmao-denver jmao-denver requested a review from rcaudy as a code owner July 27, 2023 16:33
@jmao-denver jmao-denver changed the title Add conv_null option for DH nulls to pd.NA Add conv_null option in to_pandas() to convert DH nulls to pd.NA Jul 27, 2023
chipkent
chipkent requested changes Jul 31, 2023
View reviewed changes
py/server/deephaven/constants.py Outdated Show resolved Hide resolved
py/server/tests/test_constants.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Show resolved Hide resolved
py/server/tests/test_pandas.py Outdated Show resolved Hide resolved
jjbrosnan
jjbrosnan reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@jjbrosnan jjbrosnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to a comment and feedback on the null/nan stuff

chipkent
chipkent previously approved these changes Aug 2, 2023
View reviewed changes
@jmao-denver jmao-denver enabled auto-merge (squash) August 2, 2023 17:53
@jmao-denver jmao-denver merged commit 6871f6d into deephaven:main Aug 2, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

How-to: https://github.com/deephaven/deephaven.io/issues/2986
Reference: https://github.com/deephaven/deephaven.io/issues/2985

@jmao-denver jmao-denver deleted the 4207-pd-np-null-conv branch August 25, 2023 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jjbrosnan jjbrosnan jjbrosnan left review comments

@alexpeters1208 alexpeters1208 alexpeters1208 left review comments

@chipkent chipkent chipkent approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@jmao-denver jmao-denver

Labels
DocumentationNeeded python-server-side ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
July 2023
5 participants
@jmao-denver @deephaven-internal @chipkent @alexpeters1208 @jjbrosnan