Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R Client - UpdateBy #4412

Merged
merged 55 commits into from
Sep 29, 2023
Merged

R Client - UpdateBy #4412

merged 55 commits into from
Sep 29, 2023

Conversation

alexpeters1208
Copy link
Contributor

@alexpeters1208 alexpeters1208 commented Aug 30, 2023 •
edited
Loading

Introduces the UpdateBy operation and unit tests to the R client.

@alexpeters1208 alexpeters1208 self-assigned this Aug 30, 2023
@alexpeters1208 alexpeters1208 changed the title R Client 3.0 - UpdateBy R Client - UpdateBy Aug 30, 2023
chipkent
chipkent requested changes Sep 26, 2023
View reviewed changes
R/rdeephaven/R/utility_functions.R Outdated Show resolved Hide resolved
R/rdeephaven/inst/tests/testthat/test_update_by.R Outdated Show resolved Hide resolved
R/rdeephaven/R/utility_classes.R Outdated Show resolved Hide resolved
R/rdeephaven/R/utility_classes.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/utility_functions.R Show resolved Hide resolved
chipkent
chipkent reviewed Sep 29, 2023
View reviewed changes
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
R/rdeephaven/R/update_by_ops_wrapper.R Outdated Show resolved Hide resolved
@alexpeters1208
Copy link
Contributor Author

Here is a ticket for continued discussion of R docs: #4573

@alexpeters1208 alexpeters1208 merged commit 5027d09 into deephaven:main Sep 29, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
@alexpeters1208 alexpeters1208 deleted the update_by branch September 29, 2023 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@alexpeters1208 alexpeters1208

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. r-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpeters1208 @chipkent