Removed ParquetHadoop module #4457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
feature request
|
Link to PR which does a similar change on the enterprise side as part of a larger commit. |
|
From our slack discussion, I'll push a small set of changes to this branch to try to simplify a bit. |
malhotrashivam
commented
Sep 8, 2023
niloc132
reviewed
Sep 8, 2023
| @@ -19,6 +19,8 @@ dependencies { | |||
| api project(':engine-stringset') | |||
|
|
|||
| implementation project(':extensions-parquet-base') | |||
| Classpaths.inheritParquetHadoop(project) | |||
There was a problem hiding this comment.
Note to other reviewers, this was added because it should have been here to begin with - previously we picked it up transitively from our other parquet projects, but there is no actual need for it as an api dependency. Instead, this project should have declared it as an implementation dep, which it now does.
niloc132
previously approved these changes
Sep 8, 2023
nbauernfeind
previously approved these changes
Sep 11, 2023
devinrsmith
reviewed
Sep 12, 2023
ParquetHadoop/src/main/java/io/deephaven/parquet/base/tempfix/ParquetMetadataConverter.java
Show resolved
Hide resolved
rcaudy
reviewed
Sep 12, 2023
malhotrashivam
dismissed stale reviews from nbauernfeind and niloc132
via
9df40eb
rcaudy
approved these changes
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #901
Closes #806