Add agg_all_by() to the R client and add error handling around empty aggregations in agg_by()
#4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpeters1208
added
NoDocumentationNeeded
NoReleaseNotesNeeded
# Conflicts: # R/rdeephaven/src/client.cpp
chipkent
requested changes
Sep 8, 2023
chipkent
requested changes
Sep 13, 2023
chipkent
approved these changes
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes from #4464, so that should be merged first to minimize the diff. This PR is a blocker on #4363, because the correctness of the docstrings for
agg_by()depend on whether it will accept empty aggregations.This PR introduces
agg_all_by()to the R wrapping, and adds C++ binding to support it. It also removes the ability ofagg_by()to accept empty aggregations liketh$agg_by(agg_min(), by = "grouping")by adding additional checks at the R level.The current C++ level implementation of
agg_all_by()andagg_by()will change based on recent conversations over the deprecatedComboAggRequestthat they both utilize, but this PR aims to provide a stable API that can be distributed and documented independently of any underlying C++ changes.