ParquetTableWriter Extract/Replicate Transfer Kernels #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
core
nbauernfeind
force-pushed
the
transfer_kernel
branch
from
8dab591
to
1838705
Compare
nbauernfeind
changed the title
nbauernfeind
force-pushed
the
transfer_kernel
branch
from
1838705
to
ae7d753
Compare
rcaudy
requested changes
Sep 20, 2023
There was a problem hiding this comment.
I think this PR adds some value, by making ParquetTableWriter less cumbersome and enabling replication. That said, we should bring back to bifurcation between the good primitive transfers and the ones that have to copy to ints first. I also think we should consider keeping the class hierarchy we had, and just replicating sub-classes.
Likely the redundant statistics gathering should be ripped out, or removed from the lower level if we're certain it's better this way. If we're going to do that, null counting needs to be added at the higher level.
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/transfer/TransferObject.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/transfer/TransferObject.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/transfer/IntTransfer.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/transfer/EncodedTransfer.java
Outdated
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
transfer_kernel
branch
from
242525e
to
9b61f8b
Compare
rcaudy
approved these changes
Sep 21, 2023
nbauernfeind
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a portion of DH-12664 pushdown/predicates in this commit.