Retry decompressing with LZ4_RAW if LZ4 fails #4480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
feature request
malhotrashivam
changed the title
malhotrashivam
force-pushed
the
sm-pq-lz4-retry
branch
from
f286643
to
8798efa
Compare
niloc132
reviewed
Sep 12, 2023
...mpression/src/main/java/io/deephaven/parquet/compress/DeephavenCompressorAdapterFactory.java
Outdated
Show resolved
Hide resolved
niloc132
reviewed
Sep 13, 2023
...mpression/src/main/java/io/deephaven/parquet/compress/DeephavenCompressorAdapterFactory.java
Outdated
Show resolved
Hide resolved
...mpression/src/main/java/io/deephaven/parquet/compress/DeephavenCompressorAdapterFactory.java
Show resolved
Hide resolved
...mpression/src/main/java/io/deephaven/parquet/compress/DeephavenCompressorAdapterFactory.java
Outdated
Show resolved
Hide resolved
|
Might be simpler to see this folded into #4446, but I can see it either way. |
|
Combining this PR with #4446 |
malhotrashivam
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR combined with #4446
The retry mechanism is particularly useful for decompressing parquet files that are compressed with LZ4_RAW but tagged as LZ4 in the metadata.
Interesting reads: