Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto convert Java values(arrays/scalar) to Numpy ones and convert DH nulls based on the annotations of the params of a Py UDF #4502

Merged
merged 18 commits into from
Dec 1, 2023
Merged

auto convert Java values(arrays/scalar) to Numpy ones and convert DH nulls based on the annotations of the params of a Py UDF #4502

merged 18 commits into from
Dec 1, 2023

Conversation

jmao-denver
Copy link
Contributor

@jmao-denver jmao-denver commented Sep 16, 2023 •
edited
Loading

Fixes #4208
Fixes #4558

@jmao-denver jmao-denver added this to the September 2023 milestone Sep 16, 2023
@jmao-denver jmao-denver self-assigned this Sep 16, 2023
chipkent
chipkent requested changes Sep 22, 2023
View reviewed changes
py/server/deephaven/dtypes.py Outdated Show resolved Hide resolved
py/server/tests/test_pyfunc_param_null.py Outdated Show resolved Hide resolved
py/server/tests/test_pyfunc_param_null.py Outdated Show resolved Hide resolved
py/server/tests/test_pyfunc_param_null.py Outdated Show resolved Hide resolved
py/server/tests/test_pyfunc_param_null.py Outdated Show resolved Hide resolved
py/server/tests/test_vectorization.py Outdated Show resolved Hide resolved
py/server/tests/test_vectorization.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Show resolved Hide resolved
chipkent
chipkent requested changes Sep 25, 2023
View reviewed changes
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/numpy.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
chipkent
chipkent reviewed Sep 26, 2023
View reviewed changes
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Outdated Show resolved Hide resolved
py/server/tests/test_pyfunc_param_null.py Outdated Show resolved Hide resolved
@jmao-denver jmao-denver marked this pull request as draft October 23, 2023 17:05
@jmao-denver jmao-denver marked this pull request as ready for review October 25, 2023 19:08
@jmao-denver jmao-denver marked this pull request as draft November 15, 2023 14:55
@jmao-denver jmao-denver marked this pull request as ready for review November 21, 2023 22:13
@jmao-denver jmao-denver changed the title auto convert DH nulls in params to py UDF auto convert Java arrays to Numpy arrays and convert DH nulls based on the annotations of the params for a Py UDF Nov 21, 2023
@jmao-denver jmao-denver changed the title auto convert Java arrays to Numpy arrays and convert DH nulls based on the annotations of the params for a Py UDF auto convert Java arrays to Numpy arrays and convert DH nulls based on the annotations of the params of a Py UDF Nov 22, 2023
chipkent
chipkent reviewed Nov 22, 2023
View reviewed changes
py/server/deephaven/dtypes.py Outdated Show resolved Hide resolved
py/server/deephaven/dtypes.py Outdated Show resolved Hide resolved
py/server/deephaven/dtypes.py Outdated Show resolved Hide resolved
py/server/deephaven/pandas.py Show resolved Hide resolved
py/server/tests/test_numba_guvectorize.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
py/server/deephaven/table.py Outdated Show resolved Hide resolved
@jmao-denver jmao-denver changed the title auto convert Java arrays to Numpy arrays and convert DH nulls based on the annotations of the params of a Py UDF auto convert Java values(arrays/scalar) to Numpy ones and convert DH nulls based on the annotations of the params of a Py UDF Nov 28, 2023
chipkent
chipkent reviewed Nov 28, 2023
View reviewed changes
py/server/deephaven/dtypes.py Outdated Show resolved Hide resolved
py/server/deephaven/dtypes.py Show resolved Hide resolved
py/server/deephaven/jcompat.py Outdated Show resolved Hide resolved
py/server/deephaven/jcompat.py Outdated Show resolved Hide resolved
py/server/deephaven/jcompat.py Outdated Show resolved Hide resolved
py/server/tests/test_udf_numpy_args.py Show resolved Hide resolved
py/server/tests/test_udf_numpy_args.py Show resolved Hide resolved
py/server/tests/test_udf_numpy_args.py Outdated Show resolved Hide resolved
py/server/tests/test_udf_numpy_args.py Outdated Show resolved Hide resolved
py/server/tests/test_udf_numpy_args.py Outdated Show resolved Hide resolved
chipkent
chipkent reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@chipkent chipkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes are good. Just need to review open items to see if any require attention or if they are all done or WNI.

@jmao-denver jmao-denver merged commit 19b1d7e into deephaven:main Dec 1, 2023
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

How-to: https://github.com/deephaven/deephaven.io/issues/3514
Reference: https://github.com/deephaven/deephaven.io/issues/3515

@jmao-denver jmao-denver deleted the 4208-dhnull-to-pdNA-in-py-UDF branch December 18, 2023 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

@nbauernfeind nbauernfeind Awaiting requested review from nbauernfeind

Assignees

@jmao-denver jmao-denver

Labels
breaking DocumentationNeeded python-server-side ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
September 2023
3 participants
@jmao-denver @deephaven-internal @chipkent