Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DH to work with byte arrays #4507

Merged
merged 2 commits into from
Sep 19, 2023
Merged

DH to work with byte arrays #4507

merged 2 commits into from
Sep 19, 2023

Conversation

ilyaberdnikov
Copy link
Contributor

@ilyaberdnikov ilyaberdnikov commented Sep 18, 2023 •
edited by nbauernfeind
Loading

Fixes #4355.

This is currently a very rough hack, but it does work locally. Not sure what it breaks.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ilyaberdnikov ilyaberdnikov mentioned this pull request Sep 18, 2023
Closed
@rcaudy rcaudy added barrage core Core development tasks DocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Sep 18, 2023
nbauernfeind
nbauernfeind reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@nbauernfeind nbauernfeind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the CLA (see the automated message above).

Once you do and address my comments, I'll kick of a "nightly" build which runs a suite of tests (many of which go through the ChunkInputStreamGenerator code path).

Thank you for the PR; once merged I'll probably tack on support for the remaining primitive arrays. (No reason the java client shouldn't be supporting these.)

...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java Show resolved Hide resolved
java-client/flight-examples/src/main/java/io/deephaven/client/examples/AddToInputTable.java Outdated Show resolved Hide resolved
@nbauernfeind nbauernfeind self-assigned this Sep 18, 2023
@nbauernfeind nbauernfeind added this to the September 2023 milestone Sep 18, 2023
@ilyaberdnikov
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ilyaberdnikov
Copy link
Contributor Author

recheck

@nbauernfeind
Copy link
Member

nbauernfeind commented Sep 18, 2023 •
edited
Loading

Your PR looks good to me so far. I've just kicked off that suite of tests. When they pass (plus or minus a known random failure) then I'll get this merged.

Thank you so much for your contribution!

Here is the CI link if you are curious: https://github.com/nbauernfeind/deephaven-core/actions/runs/6227600752/

@nbauernfeind nbauernfeind merged commit bc4944f into deephaven:main Sep 19, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

How-to: https://github.com/deephaven/deephaven.io/issues/3202
Reference: https://github.com/deephaven/deephaven.io/issues/3201

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nbauernfeind nbauernfeind nbauernfeind approved these changes

Assignees

@nbauernfeind nbauernfeind

Labels
barrage core Core development tasks DocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.

Support in Java client for publishing columns of type byte[]
4 participants
@ilyaberdnikov @nbauernfeind @deephaven-internal @rcaudy