Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python tests for FunctionGeneratedTable #4511

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix Python tests for FunctionGeneratedTable #4511

merged 2 commits into from
Sep 18, 2023

Conversation

rbasralian
Copy link
Contributor

No description provided.

@rcaudy rcaudy added bug Something isn't working query engine core Core development tasks NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Sep 18, 2023
@rcaudy rcaudy added this to the September 2023 milestone Sep 18, 2023
@rbasralian rbasralian marked this pull request as ready for review September 18, 2023 22:37
jmao-denver
jmao-denver approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbasralian rbasralian merged commit 7b8bc7d into deephaven:main Sep 18, 2023
18 of 20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
@rbasralian rbasralian deleted the raffi_fix_fgt_take2 branch September 19, 2023 00:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@jmao-denver jmao-denver jmao-denver approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

Assignees

@rbasralian rbasralian

Labels
bug Something isn't working core Core development tasks NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. query engine
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@rbasralian @jmao-denver @rcaudy