Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Groovy container w/ examples and Redpanda #4673

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

jjbrosnan
Copy link
Contributor

We're adding Kafka Groovy docs, so having this to link to will be helpful, even if it's basically identical to the Python one.

@jjbrosnan jjbrosnan added this to the October 2023 milestone Oct 19, 2023
@jjbrosnan jjbrosnan self-assigned this Oct 19, 2023
@jjbrosnan jjbrosnan modified the milestones: October 2023, November 2023 Nov 9, 2023
…es and change docker-compose to docker compose in shell commands
@jjbrosnan
Copy link
Contributor Author

This PR now not only adds a Groovy-examples-redpanda docker compose deployment, it also adds:

  • A Python + Redpanda deployment without examples
  • A Groovy + Redpanda deployment without examples

It also removes any docker-compose shell commands in favor of docker compose v2 syntax, docker compose.

@jjbrosnan
Copy link
Contributor Author

I should also mention this removes our All-AI deployments, as we decided to no longer publish those images.

Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments that I think apply to a lot of files - didn't repeat the advice for every single file though...

containers/groovy-examples-redpanda/README.md Outdated Show resolved Hide resolved
containers/groovy-examples/README.md Show resolved Hide resolved
containers/groovy-redpanda/README.md Outdated Show resolved Hide resolved
containers/groovy/README.md Show resolved Hide resolved
containers/python-examples-redpanda/README.md Show resolved Hide resolved
containers/python-redpanda/docker-compose.yml Outdated Show resolved Hide resolved
Comment on lines 14 to 27
command:
- redpanda
- start
- --smp
- '1'
- --reserve-memory
- 0M
- --overprovisioned
- --node-id
- '0'
- --kafka-addr
- PLAINTEXT://0.0.0.0:29092,OUTSIDE://0.0.0.0:9092
- --advertise-kafka-addr
- PLAINTEXT://redpanda:29092,OUTSIDE://localhost:9092
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should adopt the formatting style redpanda uses for this:

    command:
      - redpanda
      - start
      - --kafka-addr internal://0.0.0.0:9092,external://0.0.0.0:19092
      - --advertise-kafka-addr internal://redpanda:9092,external://localhost:19092
      - --schema-registry-addr internal://0.0.0.0:8081,external://0.0.0.0:18081
      - --smp 1
      - --memory 1G
      - --mode dev-container

I've modified this from https://docs.redpanda.com/current/get-started/quick-start/; we should test it in all of the different compose files to make sure it works. Do we use the schema registry for any of our examples?

Copy link
Contributor Author

@jjbrosnan jjbrosnan Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we do. I've made updates that make our syntax consistent with Redpanda and tested it to make sure it works with the examples in our Kafka documentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we're consistent w/ the redpanda quickstart - they use internal and external, and use dev-container.

Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See item I re-opened.

Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you've run these examples successfully, LGTM.

@jjbrosnan jjbrosnan merged commit 4f5cc3b into deephaven:main Jan 17, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants