Address PartitionedTable transform and partitionedTransform dependency issues #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
added
bug
…titionedTable.p . Clean up some JavaDocs.
rcaudy
force-pushed
the
rwc-ptxformdeps
branch
from
227244f
to
bf06f3b
Compare
cpwright
approved these changes
Nov 28, 2023
| final Table initialGroupsTable = LivenessScopeStack.computeEnclosed( | ||
| () -> ((Table) initialGroups).selectDistinct(groupByColumns).snapshot(), | ||
| () -> ((Table) initialGroups).isRefreshing(), | ||
| Table::isRefreshing); |
There was a problem hiding this comment.
So how could this actually do anything other than return false (definitionally basd on the snapshot()?
There was a problem hiding this comment.
It could't. I just felt like it was better to go through the motions, especially in case the code is ever copy-pasted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4881