-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs CI Rework for Versioned Deploy #4904
Docs CI Rework for Versioned Deploy #4904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not audit the actual arguments to rsync, but we'll want other eyes to look in depth before we merge.
It would be good to see a tree
of the proposed layout.
co-pilot seems to think --mkpath isn't an option, what does it do? |
In order to place versioned directories like release/v0.30.0, the remote-path action attribute has a directory that doesn't exist. --mkpath creates it. I'm not sure how we would put multiple deploy directories side-by-side with "--delete" turned on, Maybe have a 1st job that makes the version directory and doesn't do delete? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I'm happy to merge this given the brand new directory on the remote_path. Please get approval from @dsmmcken before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and should be low risk to merge. I'll make whatever changes we need on the other side of the fence once deployed.
Added docs-ci-v2.yml to deploy to directory deephaven-core-v2, while docs-ci.yml remains unchanged.
New Directory structure