New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add `getVariableDefinition` method #4917

Closed

mofojed wants to merge 1 commit into deephaven:main from mofojed:get-variable

Member

mofojed commented Dec 6, 2023

In cases of embedded widgets, we want to be able to just fetch the widget by just name, as we may not have type
We already have a utility method doing this in JS: https://github.com/deephaven/web-client-ui/blob/4c0200e71e350fcf5261b0cc28440cb798bec207/packages/jsapi-utils/src/ConnectionUtils.ts#L18
Figure we should just expose the getVariableDefinition, since it's doing the exact same thing


          feat: Add getVariableDefinition method

051dbb7

- In cases of embedded widgets, we want to be able to just fetch the widget by just name, as we may not have type
- We already have a utility method doing this in JS: https://github.com/deephaven/web-client-ui/blob/4c0200e71e350fcf5261b0cc28440cb798bec207/packages/jsapi-utils/src/ConnectionUtils.ts#L18
- Figure we should just expose the getVariableDefinition, since it's doing the exact same thing

mofojed added NoDocumentationNeeded NoReleaseNotesNeeded labels

mofojed requested a review from niloc132

December 6, 2023 01:00

mofojed self-assigned this

mofojed closed this

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NoDocumentationNeeded NoReleaseNotesNeeded