Barrage Subscription/Snapshot Future's Manage Additional Liveness Until First #get #4944

nbauernfeind · 2023-12-13T19:44:57Z

Fixes #4928.

…s Until First #get

java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshotImpl.java

java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java

rcaudy

Merge if tests look good

nbauernfeind added core Core development tasks barrage-wrkr2wrkr labels Dec 13, 2023

nbauernfeind added this to the December 2023 milestone Dec 13, 2023

nbauernfeind requested review from abaranec and rcaudy December 13, 2023 19:44

nbauernfeind self-assigned this Dec 13, 2023

BarrageSubscription/SnapshotImpl's Future's Manage Additional Livenes…

b284a47

…s Until First #get

nbauernfeind force-pushed the barrage_future branch from 09f1230 to b284a47 Compare December 13, 2023 20:21

nbauernfeind added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Dec 13, 2023

Also on completeExceptionally

9a0fd32

rcaudy reviewed Dec 13, 2023

View reviewed changes

Ryan's & My Changes

7497ac6

rcaudy reviewed Dec 14, 2023

View reviewed changes

java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java Outdated Show resolved Hide resolved

Feedback

b12eb1b

rcaudy previously approved these changes Dec 14, 2023

View reviewed changes

Andy also asked for the table definition..

92c1183

nbauernfeind dismissed rcaudy’s stale review via 92c1183 December 14, 2023 23:35

Change how to get the TableDefinition

b934b43

rcaudy approved these changes Dec 15, 2023

View reviewed changes

nbauernfeind merged commit a5eb055 into deephaven:main Dec 15, 2023
19 checks passed

github-actions bot locked and limited conversation to collaborators Dec 15, 2023

Provide feedback