Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate file headers #5207

Merged
merged 51 commits into from
Mar 7, 2024
Merged

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Mar 1, 2024

Automates license headers and updates generated headers to more
clearly indicate what should be changed. Removes spotless exclusions
where possible, using file comments instead when necessary. Disables
spotless for files not under the dh license.

This will fail to build, the next commit, #5208 will apply these
changes across the codebase.

Fixes #1997

@niloc132 niloc132 changed the title Update license headers Automate file headers Mar 1, 2024
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to do shallow review. Things look ok. Will try running commands. The // @formatter:off is much nicer than trying to finely specify the excludes.

@niloc132
Copy link
Member Author

niloc132 commented Mar 5, 2024

Tests are passing of the finished product: https://github.com/niloc132/deephaven-core/actions/runs/8162832698

@niloc132 niloc132 marked this pull request as ready for review March 7, 2024 00:41
@devinrsmith devinrsmith merged commit 7113b72 into deephaven:main Mar 7, 2024
16 of 19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace license-gradle-plugin with spotless
2 participants