refactor: Rewrite JS API to share server implementation of Flight/Barrage

.github/CODEOWNERS

@@ -24,4 +24,4 @@
 /py @chipkent @jmao-denver @rcaudy
 /R @chipkent @alexpeters1208 @rcaudy
 *.proto @devinrsmith @nbauernfeind @niloc132 @rcaudy
-*.gwt.xml @niloc132 @rcaudy @nbauernfeind
+*.gwt.xml @niloc132 @rcaudy @nbauernfeind

Base/src/main/resources/io/deephaven/base/Base.gwt.xml

@@ -1,4 +1,4 @@
 <module>
     <source path="" includes="MathUtil.java" />
     <source path="verify" />
-</module>
+</module>

IO/src/main/resources/io/deephaven/io/IO.gwt.xml

@@ -1,3 +1,3 @@
 <module>
     <source path="streams" includes="ByteBufferInputStream.java" />
-</module>
+</module>

Util/src/main/java/io/deephaven/util/MultiException.java

@@ -105,7 +105,7 @@ public void printStackTrace(PrintStream s) {
     @Override
     public String getMessage() {
         StringBuilder sb = new StringBuilder();
-        sb.append(super.getMessage()).append(": \n");
+        sb.append(super.getMessage()).append(":\n");
         for (int i = 0; i < causes.length; i++) {
             sb.append("Cause ").append(i).append(": ");
             sb.append(causes[i].toString());

Util/src/main/resources/io/deephaven/Util.gwt.xml

@@ -7,4 +7,4 @@
     <source path="util/mutable" />
     <source path="util/compare" />
     <source path="" includes="UncheckedDeephavenException.java" />
-</module>
+</module>

buildSrc/src/main/groovy/io.deephaven.repository-conventions.gradle

@@ -1,8 +1,5 @@
 repositories {
     mavenCentral()
-    maven {
-        url 'https://oss.sonatype.org/content/repositories/snapshots/'
-    }
     maven {
         url 'https://jitpack.io'
         content {

engine/chunk/src/main/resources/io/deephaven/chunk/Chunk.gwt.xml

@@ -3,4 +3,4 @@
     <inherits name="io.deephaven.Util" />
     <source path="" />
     <source path="util/pools" excludes="ChunkPoolReleaseTracking.java" />
-</module>
+</module>

engine/primitive/src/main/resources/io/deephaven/engine/primitive/function/Function.gwt.xml

@@ -1,3 +1,3 @@
 <module>
     <source path="" />
-</module>
+</module>

extensions/barrage/src/main/resources/io/deephaven/extensions/barrage/Barrage.gwt.xml

@@ -11,4 +11,4 @@
         <exclude name="DefaultChunkReadingFactory.java" />
         <exclude name="DefaultChunkInputStreamGeneratorFactory.java" />
     </source>
-</module>
+</module>

gradle/libs.versions.toml

@@ -77,7 +77,7 @@ trove = "3.0.3"
 undercouch = "2.15.1"
 univocity = "2.6.0"
 vertispan-nio = "1.0-alpha-2"
-vertispan-flatbuffers-gwt = "1.12.0-1-SNAPSHOT"
+vertispan-flatbuffers-gwt = "1.12.0-1"
 vertispan-ts-defs = "1.0.0-RC4"
 
 # test versions

props/configs/src/main/resources/dh-defaults.prop

@@ -57,12 +57,15 @@ web.storage.notebook.directory=/notebooks
 web.webgl=true
 web.webgl.editable=true
 
+# Default to not flattening web viewports, but allow it as an option
+web.flattenViewports=false
+
 # List of configuration properties to provide to unauthenticated clients, so that they can decide how best to prove their
 # identity to the server.
 authentication.client.configuration.list=AuthHandlers
 
 # List of configuration properties to provide to authenticated clients, so they can interact with the server.
-client.configuration.list=java.version,deephaven.version,barrage.version,groovy.version,python.version,http.session.durationMs,file.separator,web.storage.layout.directory,web.storage.notebook.directory,web.webgl,web.webgl.editable
+client.configuration.list=java.version,deephaven.version,barrage.version,groovy.version,python.version,http.session.durationMs,file.separator,web.storage.layout.directory,web.storage.notebook.directory,web.webgl,web.webgl.editable,web.flattenViewports
 
 # Version list to add to the configuration property list. Each `=`-delimited pair denotes a short name for a versioned
 # jar, and a class that is found in that jar. Any such keys will be made available to the client.configuration.list

web/client-api/src/main/java/io/deephaven/web/client/api/JsRangeSet.java

@@ -24,6 +24,9 @@ public class JsRangeSet {
     private final RangeSet range;
 
     public static JsRangeSet ofRange(double first, double last) {
+        if (first > last) {
+            throw new IllegalStateException(first + " > " + last);
+        }
         return new JsRangeSet(RangeSet.ofRange((long) first, (long) last));
     }
 

web/client-api/src/main/java/io/deephaven/web/client/api/JsTable.java

@@ -715,7 +715,7 @@ public TableViewportSubscription setViewport(double firstRow, double lastRow,
 
             // rewrap current state in a new one, when ready the viewport will be applied
             TableViewportSubscription replacement =
-                    new TableViewportSubscription(firstRow, lastRow, columnsCopy, updateIntervalMs, this);
+                    TableViewportSubscription.make(firstRow, lastRow, columnsCopy, updateIntervalMs, this);
 
             subscriptions.put(currentState.getHandle(), replacement);
             return replacement;

web/client-api/src/main/java/io/deephaven/web/client/api/TableData.java

@@ -3,7 +3,6 @@
 //
 package io.deephaven.web.client.api;
 
-import com.vertispan.tsdefs.annotations.TsName;
 import com.vertispan.tsdefs.annotations.TsTypeRef;
 import com.vertispan.tsdefs.annotations.TsUnion;
 import com.vertispan.tsdefs.annotations.TsUnionMember;
@@ -99,6 +98,7 @@ default Row get(RowPositionUnion index) {
      * @param column the column to read
      * @return the value in the table
      */
+    // TODO (deephaven-core#5927) Consider a get/fillChunk API as an efficient alternative
     @JsMethod
     default Any getData(RowPositionUnion index, Column column) {
         if (index.isLongWrapper()) {

web/client-api/src/main/java/io/deephaven/web/client/api/WorkerConnection.java

@@ -18,10 +18,12 @@
 import io.deephaven.javascript.proto.dhinternal.arrow.flight.protocol.flight_pb_service.FlightServiceClient;
 import io.deephaven.javascript.proto.dhinternal.browserheaders.BrowserHeaders;
 import io.deephaven.javascript.proto.dhinternal.grpcweb.grpc.Code;
+import io.deephaven.javascript.proto.dhinternal.grpcweb.grpc.UnaryOutput;
 import io.deephaven.javascript.proto.dhinternal.io.deephaven.proto.application_pb.FieldInfo;
 import io.deephaven.javascript.proto.dhinternal.io.deephaven.proto.application_pb.FieldsChangeUpdate;
 import io.deephaven.javascript.proto.dhinternal.io.deephaven.proto.application_pb.ListFieldsRequest;
 import io.deephaven.javascript.proto.dhinternal.io.deephaven.proto.application_pb_service.ApplicationServiceClient;
+import io.deephaven.javascript.proto.dhinternal.io.deephaven.proto.config_pb.ConfigValue;
 import io.deephaven.javascript.proto.dhinternal.io.deephaven.proto.config_pb.ConfigurationConstantsRequest;
 import io.deephaven.javascript.proto.dhinternal.io.deephaven.proto.config_pb.ConfigurationConstantsResponse;
 import io.deephaven.javascript.proto.dhinternal.io.deephaven.proto.config_pb_service.ConfigService;
@@ -198,6 +200,8 @@ private enum State {
     private Map<String, JsVariableDefinition> knownFields = new HashMap<>();
     private ResponseStreamWrapper<FieldsChangeUpdate> fieldsChangeUpdateStream;
 
+    private ConfigurationConstantsResponse constants;
+
     public WorkerConnection(QueryConnectable<?> info) {
         this.info = info;
         this.config = new ClientConfiguration();
@@ -478,11 +482,11 @@ this, ConfigService.GetConfigurationConstants, new ConfigurationConstantsRequest
                     }
 
                     // Read the timeout from the server, we'll refresh at less than that
-                    result.getMessage().getConfigValuesMap().forEach((item, key) -> {
-                        if (key.equals("http.session.durationMs")) {
-                            sessionTimeoutMs = Double.parseDouble(item.getStringValue());
-                        }
-                    });
+                    constants = result.getMessage();
+                    ConfigValue sessionDuration = constants.getConfigValuesMap().get("http.session.durationMs");
+                    if (sessionDuration != null && sessionDuration.hasStringValue()) {
+                        sessionTimeoutMs = Double.parseDouble(sessionDuration.getStringValue());
+                    }
 
                     // schedule an update based on our currently configured delay
                     scheduledAuthUpdate = DomGlobal.setTimeout(ignore -> {
@@ -1325,6 +1329,10 @@ public ClientConfiguration getConfig() {
         return config;
     }
 
+    public ConfigValue getServerConfigValue(String key) {
+        return constants.getConfigValuesMap().get(key);
+    }
+
     public void onOpen(BiConsumer<Void, String> callback) {
         switch (state) {
             case Connected:

web/client-api/src/main/java/io/deephaven/web/client/api/barrage/CompressedRangeSetReader.java

@@ -175,7 +175,7 @@ public RangeSet read(ByteBuffer data) {
                     if (pending >= 0) {
                         append(pending);
                     }
-                    return RangeSet.fromSortedRanges(sortedRanges.toArray(new Range[0]));
+                    return RangeSet.fromSortedRanges(sortedRanges);
                 default:
                     throw new IllegalStateException("Bad command: " + command + " at position " + data.position());
             }

web/client-api/src/main/java/io/deephaven/web/client/api/barrage/WebBarrageUtils.java

@@ -115,7 +115,7 @@ public static ByteBuffer serializeRanges(Set<RangeSet> rangeSets) {
         } else {
             s = new RangeSet();
             for (RangeSet rangeSet : rangeSets) {
-                rangeSet.rangeIterator().forEachRemaining(s::addRange);
+                s.addRangeSet(rangeSet);
             }
         }