Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor PartitioningColumnDataIndex in support of refreshing Iceberg tables #5921

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Aug 8, 2024

Improve and refactor PartitioningColumnDataIndex to support the expected types of location changes that will be introduced by refreshing Iceberg tables:

  1. Move responsibility for location table row set shifting to RegionedColumnSourceManager
  2. Support location removes and resurrections in PartitioningColumnDataIndex
  3. Correct modify handling (previous tracking) in PartitioningColumnDataIndex

…ation row set shifting to the RegionedColumnSourceManager, (2) support location removes and resurrections in the PartitioningColumnDataIndex, and (3) correct modify handling (previous tracking)
@rcaudy rcaudy added query engine core Core development tasks labels Aug 8, 2024
@rcaudy rcaudy added this to the 0.37.0 milestone Aug 8, 2024
@rcaudy rcaudy requested a review from lbooker42 August 8, 2024 20:10
@rcaudy rcaudy self-assigned this Aug 8, 2024
@rcaudy rcaudy changed the title feat: Refactor PartitioningColumnDataIndex in support of ticking Iceberg feat: Refactor PartitioningColumnDataIndex in support of refreshing Iceberg tables Aug 8, 2024
@rcaudy
Copy link
Member Author

rcaudy commented Aug 8, 2024

This PR is intended to be merged ahead of or with #5707. It currently needs more unit testing. That should come along with the refreshing Iceberg changes.

@rcaudy rcaudy added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Aug 8, 2024
@rcaudy
Copy link
Member Author

rcaudy commented Aug 15, 2024

Note, there may be conflicts due to #5942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core development tasks NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant