fix: Don't recreate JS TreeTable subscriptions when viewport changes #6060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue where subscription recreation would release an export ticket that was still needed for the next subscription. Also improves tree viewport performance by sending changes instead of waiting for a new subscription to exist. Fixes deephaven#6053
niloc132
added
jsapi
NoDocumentationNeeded
ReleaseNotesNeeded
|
Should see about adding an integration test for this case. |
mofojed
requested changes
Sep 12, 2024
There was a problem hiding this comment.
You just need to update your PR description - this fixes #6056, not #6053.
Tested using the steps in the description of #6056. The dependency released error is fixed. I am seeing an error still in the browser console logs when repeating those steps:
But this appears to be a Web UI side issue (appears before your JSAPI change as well), so I'll split the ticket off to resolve that.
nbauernfeind
previously approved these changes
Sep 12, 2024
mofojed
approved these changes
Sep 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where subscription recreation would release an export ticket that was still needed for the next subscription.
Also improves tree viewport performance by sending changes instead of waiting for a new subscription to exist.
Fixes #6056