perf: Embed WindowCheck in TimeSeriesFilter. #6081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpwright
added
ReleaseNotesNeeded
rcaudy
reviewed
Sep 19, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/WouldMatchOperation.java
Outdated
Show resolved
Hide resolved
| } else if (refilterUnmatchedRequested) { | ||
| // things that are added or removed are already reflected in source.getRowSet | ||
| final WritableRowSet unmatchedRows = source.getRowSet().minus(getRowSet()); | ||
| // we must check rows that have been modified instead of just preserving them | ||
| if (upstream != null) { | ||
| unmatchedRows.insert(upstream.modified()); | ||
| } | ||
| if (refilterRequestedRowset != null) { | ||
| unmatchedRows.insert(refilterRequestedRowset); |
There was a problem hiding this comment.
We copy() unmatchedRows below, and I think that is redundant. As-is, we're still never closing it.
engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilter.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Sep 19, 2024
|
|
||
| // Note that removed must be propagated to listeners in pre-shift keyspace. | ||
| if (upstream != null) { | ||
| upstream.shifted().unapply(postShiftRemovals); | ||
| } | ||
| update.removed.writableCast().insert(postShiftRemovals); | ||
| update.removed = postShiftRemovals; |
There was a problem hiding this comment.
I think you should close removed, or just never assign it.
There was a problem hiding this comment.
There was a comment related to this in the other part of the code where removed is created originally. Because the shift aware updates support added + removed, we need to include the original removed from the update, plus our new removals to account for rows that are added/removed as a modify w/o lighting up the entire MCS.
engine/table/src/main/java/io/deephaven/engine/table/impl/select/TimeSeriesFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/util/TestClock.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6062.