Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Embed WindowCheck in TimeSeriesFilter. #6081

Merged
merged 20 commits into from
Sep 26, 2024

Conversation

cpwright
Copy link
Contributor

Fixes #6062.

Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We addressed many concerns inline during the PR.
TestClock should be converged with existing.
TimeSeriesFilter does not need a MergedListener, just a plain old ListenerImpl.

Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@cpwright cpwright merged commit 967b203 into deephaven:main Sep 26, 2024
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

Community: deephaven/deephaven-docs-community#316

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeSeriesFilter should rewritten in terms of WindowCheck
3 participants