Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JS should modify data in redirected space, not key space #6085

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,19 @@ public void applyUpdates(WebBarrageMessage message) {

modifiedColumnSet.set(ii);

PrimitiveIterator.OfLong destIterator = column.rowsModified.indexIterator();
PrimitiveIterator.OfLong destIterator = new PrimitiveIterator.OfLong() {
private final PrimitiveIterator.OfLong wrapped = column.rowsModified.indexIterator();

@Override
public long nextLong() {
return redirectedIndexes.get(wrapped.next());
}

@Override
public boolean hasNext() {
return wrapped.hasNext();
}
};
for (int j = 0; j < column.data.size(); j++) {
Chunk<Values> chunk = column.data.get(j);
destSources[ii].fillChunk(chunk, destIterator);
Expand Down