-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(py/client-ticking): Add support for LocalDate and LocalTime #6106
feat(py/client-ticking): Add support for LocalDate and LocalTime #6106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM but I'd like to see a simple test case for the new types.
I second @jmao-denver 's comment. |
fa428f8
to
2a7711f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test looks good. It doesn't need to cover uploading arrow data to the server (doPut
). I wonder though if the C++ client needs to support doPut
and if that's been tested. I am asking because the R client depends on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are two answers to this question. The first is that if people are using our It's also possible that R is using the Arrow doPut call to push data to Deephaven directly. If so, that's outside the scope of this change and should already work. |
This PR adds support for
LocalDate
andLocalTime
to pydeephaven/ticking.Note this PR depends on #6105, so that one should be merged first.
It also depends on #6137, which also needs to be merged first.
I also add a comment to pydeephaven/README.md to remind people to make a venv.
Also note that this is a fix for #6044